[
https://issues.apache.org/jira/browse/YARN-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790510#comment-16790510
]
Wilfred Spiegelenburg commented on YARN-9344:
---------------------------------------------
Thank you [~uranus] for adding the test.
Could you clean up the test a bit? There is an unused queue in the config and
the {{<maxResources>}} does distract from the real test and it should work
without it.
The asserts from the junit test are much clearer when they have a message that
is printed when the test fails example:
{code}
assertEquals("Application has live containers and it should have none",
0, scheduler.getSchedulerApp(attId1).getLiveContainers().size());
{code}
The test does only check memory, we should also cover other resource types in
the test not just the memory resource (vcores, custom resource types).
> FS should not reserve when container capability is bigger than node total
> resource
> ----------------------------------------------------------------------------------
>
> Key: YARN-9344
> URL: https://issues.apache.org/jira/browse/YARN-9344
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Zhaohui Xin
> Assignee: Zhaohui Xin
> Priority: Major
> Attachments: YARN-9344.001.patch, YARN-9344.002.patch,
> YARN-9344.003.patch, YARN-9344.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
