[ https://issues.apache.org/jira/browse/YARN-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792415#comment-16792415 ]
Zhaohui Xin commented on YARN-9344: ----------------------------------- [~wilfreds], I updated patch. Can you help me review this? :D {quote}The test does only check memory, we should also cover other resource types in the test not just the memory resource (vcores, custom resource types). {quote} In the new patch, we tested cpu and mem separately. So there is no need to test other resource type. > FS should not reserve when container capability is bigger than node total > resource > ---------------------------------------------------------------------------------- > > Key: YARN-9344 > URL: https://issues.apache.org/jira/browse/YARN-9344 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Zhaohui Xin > Assignee: Zhaohui Xin > Priority: Major > Attachments: YARN-9344.001.patch, YARN-9344.002.patch, > YARN-9344.003.patch, YARN-9344.004.patch, YARN-9344.005.patch, > YARN-9344.006.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org