[
https://issues.apache.org/jira/browse/YARN-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797407#comment-13797407
]
Karthik Kambatla commented on YARN-1068:
----------------------------------------
Sorry, should have been clearer - was referring primarily to the PB interface
use. Let me address each point separately.
bq. Let's try to avoid adding one more server. We added AdminService separately
from client-service only for QOS sake for admin operations. HAAdminService
should be listening on the same port as all other operations.
IIUC, the suggestion is to use the RPC server from AdminService. AdminService
currently is an Active service and not an Always-On service, so doesn't start
until the RM transitions to Active. Moving the AdminService to Always-On
requires defining the semantics when the RM is Standby.
bq. Following that, we should use only one rmadmin CLI for fail-over commands
too.
To do this, we need to have RMAdminCLI extend HAAdmin, and augment the run()
method to call super.run() when applicable, and the usage needs to be augmented
to include the HAAdmin usage.
bq. RMHAProtocolService: We don't directly use PB interfaces in YARN. Let's not
change that here - use YarnRPC to create servers.
YARN expects the actual PB/PBImpl files to be at a particular location, and
can't find the corresponding files when using HAServiceProtocol from common.
Hence, had to use PB interfaces.
bq. No tests specifically for the new code added here?
The patch primarily adds command line support for HA transitions. Have tested
this manually several times on a real cluster.
> Add admin support for HA operations
> -----------------------------------
>
> Key: YARN-1068
> URL: https://issues.apache.org/jira/browse/YARN-1068
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.1.0-beta
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Labels: ha
> Attachments: yarn-1068-10.patch, yarn-1068-11.patch,
> yarn-1068-1.patch, yarn-1068-2.patch, yarn-1068-3.patch, yarn-1068-4.patch,
> yarn-1068-5.patch, yarn-1068-6.patch, yarn-1068-7.patch, yarn-1068-8.patch,
> yarn-1068-9.patch, yarn-1068-prelim.patch
>
>
> Support HA admin operations to facilitate transitioning the RM to Active and
> Standby states.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
