[
https://issues.apache.org/jira/browse/YARN-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811353#comment-16811353
]
Íñigo Goiri commented on YARN-999:
----------------------------------
Thanks [~giovanni.fumarola] for the review.
I target all of them except for the static import one.
In my opinion importing {{assertEquals()}} is better than using
{{Assert.asserEquals()}} everywhere.
With that we cover the static imports for {{assertEquals()}}, {{assertFalse}},
{{assertNotNull}}, {{assertTrue}}, and {{fail}}
The same principle applies to {{assertContainerKilled()}}, {{assertMemory()}},
{{assertNoPreemption()}}, {{assertPreemption()}}, and {{assertTime()}}.
The only one left is {{waitMemory()}} which seems pretty intuitive to me.
> In case of long running tasks, reduce node resource should balloon out
> resource quickly by calling preemption API and suspending running task.
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-999
> URL: https://issues.apache.org/jira/browse/YARN-999
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: graceful, nodemanager, scheduler
> Reporter: Junping Du
> Assignee: Íñigo Goiri
> Priority: Major
> Attachments: YARN-291.000.patch, YARN-999.001.patch,
> YARN-999.002.patch, YARN-999.003.patch, YARN-999.004.patch,
> YARN-999.005.patch, YARN-999.006.patch, YARN-999.007.patch,
> YARN-999.008.patch, YARN-999.009.patch, YARN-999.010.patch
>
>
> In current design and implementation, when we decrease resource on node to
> less than resource consumption of current running tasks, tasks can still be
> running until the end. But just no new task get assigned on this node
> (because AvailableResource < 0) until some tasks are finished and
> AvailableResource > 0 again. This is good for most cases but in case of long
> running task, it could be too slow for resource setting to actually work so
> preemption could be used here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
