[
https://issues.apache.org/jira/browse/YARN-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844613#comment-16844613
]
Adam Antal commented on YARN-9558:
----------------------------------
Thanks for taking care the failures. It's been annoying people all around
Hadoop.
The code looks good, some minor comments:
- Could you justify the timeout for {{testGuessAppOwnerWithCustomSuffix}}?
- When you refer to the "new" and "old" directory structure do you refer to the
pre- YARN-6929 and post- YARN-6929 state of the code? Could you please clarify
in the code, that you mean this? (by this time 3 years probably nobody would
know what old and new mean in this context).
- I'd add another testcase where {{yarn.nodemanager.remote-app-log-dir}} and
{{yarn.log-aggregation.%s.remote-app-log-dir}} is defined as well - in that
case guessOwner should use the folder defined by
{{yarn.log-aggregation.%s.remote-app-log-dir}}.
- {{getOwnerForAppIdOrNull}} is getting a bit lengthier. Could you please move
apart the main parts of that function? I mean something like extracting the
main blocks to the functions naming them {{attemptReturningBestGuess}} or some
more descriptive name.
Regarding functional testing I was thinking about whether it makes sense to
reading back previously written aggregated log (also reading back from the old
directory structure). As I see you tested that CLI, RM UI, etc. are working
fine, but I have some concern with backward compatibility.
> Log Aggregation testcases failing
> ---------------------------------
>
> Key: YARN-9558
> URL: https://issues.apache.org/jira/browse/YARN-9558
> Project: Hadoop YARN
> Issue Type: Bug
> Components: log-aggregation, test
> Affects Versions: 3.3.0, 3.2.1, 3.1.3
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Major
> Attachments: YARN-9558-001.patch, YARN-9558-002.patch
>
>
> Test cases related to Log Aggregation from below classes are failing
> hadoop.yarn.server.nodemanager.webapp.TestNMWebServices
> hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
>
> hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
> hadoop.yarn.client.cli.TestLogsCLI
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
