[ 
https://issues.apache.org/jira/browse/YARN-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844889#comment-16844889
 ] 

Prabhu Joseph commented on YARN-9558:
-------------------------------------

Thanks [~adam.antal] for the review. Have attached  [^YARN-9558-003.patch] 
addressing above review comments. 

Regarding backward compatibility, 
yarn.nodemanager.remote-app-log-dir-include-older config is introduced which by 
default is true, i.e, Application Log Reader will fetch the logs for a given 
application from older app log dir structure (before YARN-6929) along with new 
log dir structure. Writer won't have an issue as it writes to assigned app log 
dir structure. Have tested the reader logic with both new and old dir 
structure, it works as expected.



> Log Aggregation testcases failing
> ---------------------------------
>
>                 Key: YARN-9558
>                 URL: https://issues.apache.org/jira/browse/YARN-9558
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: log-aggregation, test
>    Affects Versions: 3.3.0, 3.2.1, 3.1.3
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: YARN-9558-001.patch, YARN-9558-002.patch, 
> YARN-9558-003.patch
>
>
> Test cases related to Log Aggregation from below classes are failing
> hadoop.yarn.server.nodemanager.webapp.TestNMWebServices 
> hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
>  
> hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices 
> hadoop.yarn.client.cli.TestLogsCLI 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to