[
https://issues.apache.org/jira/browse/YARN-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848935#comment-16848935
]
Sunil Govindan commented on YARN-9545:
--------------------------------------
Thanks
[~zsiegl], in general the DAO class looks good and forward looking. And tests
are also good and covering basic cases. I have one small concern on
{{isConnectionAlive}}. In this method, a simple bool is returned and based on
that a decision is taken whether to consider Timeline Reader is up or down..
Now I think since this method a new interface, i suggest lets return an ENUM
from this method which can renamed into {{getConnectionStatus}}/. With this, we
can return status like RUNNING, CONNECTION_FAILURE etc. And in
{{TimelineReaderWebServices}}, we can reimplement {{health}} method with switch
case statement to consider basic 2 scenarios to start with, and same will be
pretty much forward looking as well.
Thoughts/?
> Create healthcheck REST endpoint for ATSv2
> ------------------------------------------
>
> Key: YARN-9545
> URL: https://issues.apache.org/jira/browse/YARN-9545
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: ATSv2
> Affects Versions: 3.1.2
> Reporter: Zoltan Siegl
> Assignee: Zoltan Siegl
> Priority: Major
> Attachments: YARN-9545.001.patch, YARN-9545.002.patch,
> YARN-9545.003.patch
>
>
> RM UI2 and CM needs a health check url for ATSv2 service.
> Create a /health rest endpoint
> * must respond with 200 \{health: ok} if all ok
> * must respond with non 200 if any problem occurs
> * could check reader/writer connection
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
