Peter Bacsko commented on YARN-9133:

[~snemeth] similarly to YARN-9140, conflict resolution might not be trivial, 
also this file has been renamed in the meantime and it wasn't treated as a 
simple rename (see commits 
 Not sure if this is worth it.

> Make tests more easy to comprehend in TestGpuResourceHandler
> ------------------------------------------------------------
>                 Key: YARN-9133
>                 URL: https://issues.apache.org/jira/browse/YARN-9133
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9133.001.patch, YARN-9133.001.patch, 
> YARN-9133.002.patch, YARN-9133.003.patch, YARN-9133.004.patch, 
> YARN-9133.005.patch, YARN-9133.006.patch, YARN-9133.006.patch
> Tests are not quite easy to read: 
> - Some more helper methods would improve readability.
> - Eliminating the boolean flag that controls if docker is used would also 
> improve readability and clarity.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to