[ 
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907350#comment-16907350
 ] 

Szilard Nemeth commented on YARN-9133:
--------------------------------------

Hi [~pbacsko]!
+1 on latest patch for trunk and branch-3.2, committed both of them!
Thanks for your contribution!

> Make tests more easy to comprehend in TestGpuResourceHandler
> ------------------------------------------------------------
>
>                 Key: YARN-9133
>                 URL: https://issues.apache.org/jira/browse/YARN-9133
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9133.001.patch, YARN-9133.001.patch, 
> YARN-9133.002.patch, YARN-9133.003.patch, YARN-9133.004.patch, 
> YARN-9133.005.patch, YARN-9133.006.patch, YARN-9133.006.patch, 
> YARN-9133.007.patch, YARN-9133.branch-3.2.001.patch
>
>
> Tests are not quite easy to read: 
> - Some more helper methods would improve readability.
> - Eliminating the boolean flag that controls if docker is used would also 
> improve readability and clarity.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to