[
https://issues.apache.org/jira/browse/YARN-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910646#comment-16910646
]
Íñigo Goiri commented on YARN-9752:
-----------------------------------
Thanks [~abmodi] for working on this.
* For DAGAMSimulator, we should extend the javadoc with the vocabulary.
* DAGAMSimulator#pendingContainers define it as a generic List.
* Make the comments for the fields in DAGAMSimulator follow javadoc style (in
one line).
* When creating DAGAMSimulator#assignedContainers use the diamond initializer
<>.
* Could we have a test that checks something deeper for the new app type? For
example, start X tasks and see that they take Y.
> Add support for allocation id in SLS.
> -------------------------------------
>
> Key: YARN-9752
> URL: https://issues.apache.org/jira/browse/YARN-9752
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9752.001.patch, YARN-9752.002.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
