[ 
https://issues.apache.org/jira/browse/YARN-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910720#comment-16910720
 ] 

Íñigo Goiri commented on YARN-9752:
-----------------------------------

Sorry, the previous comment was for YARN-9754.

A couple comments for this
* Can we make the assert actually check the types? Right now the comment says 
the types but we could actually check it.
* It would be nice to have a comment explaining why we are getting those 
results.
* Should we add tests to check the allocation id explicitly?

> Add support for allocation id in SLS.
> -------------------------------------
>
>                 Key: YARN-9752
>                 URL: https://issues.apache.org/jira/browse/YARN-9752
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Abhishek Modi
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-9752.001.patch, YARN-9752.002.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to