[ 
https://issues.apache.org/jira/browse/YARN-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910718#comment-16910718
 ] 

Íñigo Goiri commented on YARN-9754:
-----------------------------------

Thanks [~abmodi] for working on this.
* For DAGAMSimulator, we should extend the javadoc with the vocabulary.
* DAGAMSimulator#pendingContainers define it as a generic List.
* Make the comments for the fields in DAGAMSimulator follow javadoc style (in 
one line).
* When creating DAGAMSimulator#assignedContainers use the diamond initializer 
<>.
* Could we have a test that checks something deeper for the new app type? For 
example, start X tasks and see that they take Y.

> Add support for arbitrary DAG AM Simulator.
> -------------------------------------------
>
>                 Key: YARN-9754
>                 URL: https://issues.apache.org/jira/browse/YARN-9754
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Abhishek Modi
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-9754.001.patch, YARN-9754.002.patch
>
>
> Currently, all map containers are requests as soon as Application master 
> comes up and then all reducer containers are requested. This doesn't get 
> flexibility to simulate behavior of DAG where various number of containers 
> would be requested at different time.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to