[
https://issues.apache.org/jira/browse/YARN-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917057#comment-16917057
]
Íñigo Goiri commented on YARN-9754:
-----------------------------------
Thanks [~abmodi] the test with the times looks good.
Minor comments:
* Make assertEquals a static import.
* Add some high level comment to testGetToBeScheduledContainers explaining you
are asking for a container of X,Y an Z delay, etc.
* Is there something else we can assert in TestSLSDagAMSimulator that relates
to sls_dag.json?
> Add support for arbitrary DAG AM Simulator.
> -------------------------------------------
>
> Key: YARN-9754
> URL: https://issues.apache.org/jira/browse/YARN-9754
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9754.001.patch, YARN-9754.002.patch,
> YARN-9754.003.patch, YARN-9754.004.patch
>
>
> Currently, all map containers are requests as soon as Application master
> comes up and then all reducer containers are requested. This doesn't get
> flexibility to simulate behavior of DAG where various number of containers
> would be requested at different time.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
