[ https://issues.apache.org/jira/browse/YARN-9797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918426#comment-16918426 ]
Bibin A Chundatt commented on YARN-9797: ---------------------------------------- Thank you [~BilwaST] for working on the patch Changes looks fine to me . Small clarification is related to old old code {code} if (getNumActiveApplications() < 1 || (Resources.lessThanOrEqual(resourceCalculator, lastClusterResource, queueUsage.getAMUsed(partitionName), Resources.none()))) { {code} I think the second condition is not required.. Either active application can be zero / am used resource by partition ==0 Once 1 application is activated i dont think the queueAMUsage can be zero. [~sunil.gov...@gmail.com]/[~wangda] > LeafQueue#activateApplications should use resourceCalculator#fitsIn > ------------------------------------------------------------------- > > Key: YARN-9797 > URL: https://issues.apache.org/jira/browse/YARN-9797 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Bibin A Chundatt > Assignee: Bilwa S T > Priority: Blocker > Attachments: YARN-9797-001.patch > > > Dominant resource calculator compare function check for dominant resource is > lessThan. > Incase case of AM limit we should activate application only when all the > resourceValues are less than the AM limit. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org