[ 
https://issues.apache.org/jira/browse/YARN-9797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919135#comment-16919135
 ] 

Bibin A Chundatt commented on YARN-9797:
----------------------------------------

Thank you [~BilwaST] for working on this.

Few comments

# Can you change to 16 * 1024 define 1024 as GB
{code}
Resource clusterResource = Resource.newInstance(16384L, 64, res);
{code}
# Add assert for memory usage and cpu usage too after activation.



> LeafQueue#activateApplications should use resourceCalculator#fitsIn
> -------------------------------------------------------------------
>
>                 Key: YARN-9797
>                 URL: https://issues.apache.org/jira/browse/YARN-9797
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bilwa S T
>            Priority: Blocker
>         Attachments: YARN-9797-001.patch, YARN-9797-002.patch, 
> YARN-9797-003.patch, YARN-9797-004.patch
>
>
> Dominant resource calculator compare function check for dominant resource is 
> lessThan.
> Incase case of AM limit we should activate application only when all the 
> resourceValues are less than the AM limit.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to