[
https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949691#comment-16949691
]
Jim Brennan commented on YARN-9884:
-----------------------------------
[~ebadger] good job on the re-factoring. This looks pretty good to me. I was
going to comment that there are a few of the DOCKER related enum values that
are no longer used, like INVALID_DOCKER_RO_MOUNT, and those should be removed.
Also, I think all DOCKER-specific codes should have DOCKER in the name.
I agree with [~eyang] that a single list would be even better.
> Make container-executor mount logic modular
> -------------------------------------------
>
> Key: YARN-9884
> URL: https://issues.apache.org/jira/browse/YARN-9884
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-9884.001.patch, YARN-9884.002.patch
>
>
> The current mount logic in the container-executor is interwined with docker.
> To avoid duplicating code between docker and runc, the code should be
> refactored so that both runtimes can use the same common code when possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
