[ 
https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949703#comment-16949703
 ] 

Craig Condit commented on YARN-9884:
------------------------------------

[~ebadger], this looks pretty good for the most part. However, there's one 
potential big problem... exit codes outside of the range 0-127 tend to be 
misinterpreted by shells and other tooling. Have we verified that the upper 
codes are being interpreted properly? Most kernel wait() function variations 
truncate exit codes to 8 bits, and shells treat them as signed, where negative 
values indicate death by signal -- the infamous 143 exit code in Hadoop is 
really SIGTERM (15) + 128.

> Make container-executor mount logic modular
> -------------------------------------------
>
>                 Key: YARN-9884
>                 URL: https://issues.apache.org/jira/browse/YARN-9884
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-9884.001.patch, YARN-9884.002.patch
>
>
> The current mount logic in the container-executor is interwined with docker. 
> To avoid duplicating code between docker and runc, the code should be 
> refactored so that both runtimes can use the same common code when possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to