[
https://issues.apache.org/jira/browse/YARN-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956391#comment-16956391
]
Eric Payne commented on YARN-9915:
----------------------------------
The changes look correct. The confusing thing is the the [findbugs from the
above pre-commit
build|https://builds.apache.org/job/PreCommit-YARN-Build/25017/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html]
lists the same warning in the exact same place:
{panel}
Bug type DM_NUMBER_CTOR (click for details)
In class org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics
In method
org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics.registerCustomResources()
Called method new Long(long)
Should call Long.valueOf(long) instead
At QueueMetrics.java:[line 468]
{panel}
> Fix FindBug issue in QueueMetrics
> ---------------------------------
>
> Key: YARN-9915
> URL: https://issues.apache.org/jira/browse/YARN-9915
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Minor
> Attachments: YARN-9915-01.patch
>
>
> Below FindBug issue appears in the trunk build
> {code}
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics.registerCustomResources()
> invokes inefficient new Long(long) constructor; use Long.valueOf(long)
> instead
> Bug type DM_NUMBER_CTOR (click for details)
> In class org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics
> In method
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics.registerCustomResources()
> Called method new Long(long)
> Should call Long.valueOf(long) instead
> At QueueMetrics.java:[line 468]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
