[
https://issues.apache.org/jira/browse/YARN-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956399#comment-16956399
]
Prabhu Joseph commented on YARN-9915:
-------------------------------------
Thanks [~epayne] for reviewing. Yes, the above report is confusing but Findbugs
ran twice
*one on trunk before patch: trunk Compile Tests -* where warnings are shown
-1 findbugs 1m 27s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
in trunk has 1 extant Findbugs warnings.
*And on trunk with patch: Patch Compile Tests -* the warnings are not shown and
+1 is given.
+1 findbugs 1m 23s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
*From the console output: On trunk without patch:*
{code:java}
============================================================================
============================================================================
findbugs detection: trunk
============================================================================
============================================================================
cd
/testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
/usr/bin/mvn --batch-mode
-Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build@2/yetus-m2/hadoop-trunk-patch-0
-Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true >
/testptch/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
2>&1
Elapsed: 1m 25s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
in trunk has 1 extant Findbugs warnings.
{code}
*On trunk after patch:*
{code:java}
============================================================================
============================================================================
findbugs detection: patch
============================================================================
============================================================================
cd
/testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
/usr/bin/mvn --batch-mode
-Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build@2/yetus-m2/hadoop-trunk-patch-0
-Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true >
/testptch/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
2>&1
Elapsed: 1m 12s
Starting with
/testptch/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.xml
Merging
/testptch/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.xml
Writing
/testptch/patchprocess/combined-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.xml
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
{code}
> Fix FindBug issue in QueueMetrics
> ---------------------------------
>
> Key: YARN-9915
> URL: https://issues.apache.org/jira/browse/YARN-9915
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Minor
> Attachments: YARN-9915-01.patch
>
>
> Below FindBug issue appears in the trunk build
> {code}
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics.registerCustomResources()
> invokes inefficient new Long(long) constructor; use Long.valueOf(long)
> instead
> Bug type DM_NUMBER_CTOR (click for details)
> In class org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics
> In method
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics.registerCustomResources()
> Called method new Long(long)
> Should call Long.valueOf(long) instead
> At QueueMetrics.java:[line 468]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
