[
https://issues.apache.org/jira/browse/YARN-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958153#comment-16958153
]
Íñigo Goiri commented on YARN-9768:
-----------------------------------
Sorry for the staged review... a few more comments:
* Avoid the superflous changes in TestDelegationTokenRenewer (L169, L627, L630).
* Use setClass in TestDelegationTokenRenewer#1550.
* Why is DEFAULT_RM_DELEGATION_TOKEN_RENEWER_THREAD_RETRY_MAX_ATTEMPTS = +10?
* Define futures in DelegationTokenRenewer as Map.
* Should we be more careful or define better the casting to
AbstractDelegationTokenRenewerAppEvent?
* Is the TimeoutException code path tested?
* Let's avoid DelegationTokenRenewer 1009-1019 changes, we can do those cleanup
in a separate JIRA if so.
* Add documentation for the attempt part in DelegationTokenRenewer.
* Avoid TestDelegationTokenRenewer L623 and L630.
> RM Renew Delegation token thread should timeout and retry
> ---------------------------------------------------------
>
> Key: YARN-9768
> URL: https://issues.apache.org/jira/browse/YARN-9768
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: CR Hota
> Priority: Major
> Attachments: YARN-9768.001.patch, YARN-9768.002.patch,
> YARN-9768.003.patch, YARN-9768.004.patch
>
>
> Delegation token renewer thread in RM (DelegationTokenRenewer.java) renews
> HDFS tokens received to check for validity and expiration time.
> This call is made to an underlying HDFS NN or Router Node (which has exact
> APIs as HDFS NN). If one of the nodes is bad and the renew call is stuck the
> thread remains stuck indefinitely. The thread should ideally timeout the
> renewToken and retry from the client's perspective.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
