[
https://issues.apache.org/jira/browse/YARN-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964208#comment-16964208
]
Íñigo Goiri commented on YARN-9768:
-----------------------------------
The unit test looks good, pretty much good to go.
* Avoid moving the slf4j imports in DelegationTokenRenewer.
* Add javadocs to {{getTimerTask()}} and {{DelegationTokenRenewerPoolTracker}}.
* Reduce the breaklines in DelegationTokenRenewerPoolTracker.
* Make the waitFor use lambdas.
* assertTrue(counter.get() == 1); should use assertEquals.
> RM Renew Delegation token thread should timeout and retry
> ---------------------------------------------------------
>
> Key: YARN-9768
> URL: https://issues.apache.org/jira/browse/YARN-9768
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: CR Hota
> Priority: Major
> Attachments: YARN-9768.001.patch, YARN-9768.002.patch,
> YARN-9768.003.patch, YARN-9768.004.patch, YARN-9768.005.patch
>
>
> Delegation token renewer thread in RM (DelegationTokenRenewer.java) renews
> HDFS tokens received to check for validity and expiration time.
> This call is made to an underlying HDFS NN or Router Node (which has exact
> APIs as HDFS NN). If one of the nodes is bad and the renew call is stuck the
> thread remains stuck indefinitely. The thread should ideally timeout the
> renewToken and retry from the client's perspective.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
