[
https://issues.apache.org/jira/browse/YARN-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959662#comment-16959662
]
Peter Bacsko commented on YARN-9865:
------------------------------------
[[email protected]] I agree, this is negligible. Let's skip this checkstyle
warning.
After a deeper inspection, it looks like you expanded the testcase
{{testNestedUserQueueWithGroupAsDynamicParentQueue()}}. Problem is, this test
is already too long and now it has become harder to read. We have two scenarios
in a single test.
Could you please create a new testcase and name it appropriately? If necessary,
you can rename the existing one. Ideas:
{{testNestedUserQueueWithPrimaryGroupAsDynamicParentQueue}} and
{{testNestedUserQueueWithSecondaryGroupAsDynamicParentQueue}}. Just checked,
these won't exceed the 80-char limit.
And again, use shorter assertion messages:
{noformat}
assertEquals("Expected Queue is ", "a", ctx.getQueue());
assertEquals("Expected Secondary Group is ", "asubgroup1",
...
assertEquals("Expected Queue is ", "a", ctx1.getQueue());
assertEquals("Expected Primary Group is ", "agroup",
ctx1.getParentQueue());
{noformat}
Just "Queue", "Primary group" and "Secondary group".
> Capacity scheduler: add support for combined %user + %secondary_group mapping
> -----------------------------------------------------------------------------
>
> Key: YARN-9865
> URL: https://issues.apache.org/jira/browse/YARN-9865
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-9865.001.patch, YARN-9865.002.patch
>
>
> Similiar to YARN-9841, but for secondary group.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
