[
https://issues.apache.org/jira/browse/YARN-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971482#comment-16971482
]
Szilard Nemeth commented on YARN-9865:
--------------------------------------
Hi [[email protected]]!
Patch looks good, +1, committed to trunk!
Some comments:
1. Can you please file a follow-up jira to fix the bloatedness of
yarn.scheduler.capacity.queue-mappings in CapacityScheduler.md?
There are too many values in the "value" tag. I propose to put the examples +
their description as separate lines into the "description" tag instead.
2. Another follow-up jira candite: In TestUserGroupMappingPlacementRule,
verifyQueueMapping contains many parameters. For clarity, we could refactor it
as a builder-style invocation, so we could see the named parameters. Within the
scope of this jira, one could also refactor QueueMapping and introduce a
builder for this class.
> Capacity scheduler: add support for combined %user + %secondary_group mapping
> -----------------------------------------------------------------------------
>
> Key: YARN-9865
> URL: https://issues.apache.org/jira/browse/YARN-9865
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-9865-005.patch, YARN-9865.001.patch,
> YARN-9865.002.patch, YARN-9865.003.patch, YARN-9865.004.patch
>
>
> Similiar to YARN-9841, but for secondary group.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
