[
https://issues.apache.org/jira/browse/YARN-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967556#comment-16967556
]
Peter Bacsko commented on YARN-9677:
------------------------------------
Thanks for the patch [~pingsutw]. Looks like a straightforward refactor.
+1 (non-binding)
> Make FpgaDevice and GpuDevice classes more similar to each other
> ----------------------------------------------------------------
>
> Key: YARN-9677
> URL: https://issues.apache.org/jira/browse/YARN-9677
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: kevin su
> Priority: Major
> Labels: newbie, newbie++
> Attachments: YARN-9677.001.patch
>
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.fpga.FpgaResourceAllocator.FpgaDevice
> is an inner class of FpgaResourceAllocator.
> It is not only being used from its parent class but from other classes as
> well so we are losing the purpose of the inner class, it does not really make
> sense.
> We also have
> org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.GpuDevice
> which is a similar class, but for GPU devices.
> What we could do here is to make FpgaDevice a single class and harmonize the
> packages of these 2 classes, meaning they should be "closer" to each other in
> terms of packaging.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
