[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984508#comment-16984508
]
Peter Bacsko commented on YARN-9970:
------------------------------------
Wow, checkstyle is complaining like crazy. Well, what can we do?
# Just move the lone ");" back to the previous line to get rid of all 'rparen"
identation whining.
# Small inconsistency: sometimes {{.expectedQueue("default")}} and then
{{build()}} is in the next line, sometimes
{{.expectedQueue("default").build().}} Let's just move {{build()}} call always
to the next line.
# If we don't care about visibility stuff in {{QueueMapping}}, just put
{{@SuppressWarnings("checkstyle:visibilitymodifier")}}. Alternatively, you can
actually modify code as suggested to clear the warning.
> Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping
> -------------------------------------------------------------
>
> Key: YARN-9970
> URL: https://issues.apache.org/jira/browse/YARN-9970
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-9970.001.patch, YARN-9970.002.patch,
> YARN-9970.003.patch, YARN-9970.004.patch, YARN-9970.005.patch
>
>
> Scope of this Jira is to refactor
> TestUserGroupMappingPlacementRule#verifyQueueMapping and QueueMapping class
> as discussed in
> https://issues.apache.org/jira/browse/YARN-9865?focusedCommentId=16971482&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16971482
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
