[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014920#comment-17014920
]
Szilard Nemeth commented on YARN-9970:
--------------------------------------
Hi [[email protected]],
1. Please remove unused constructors from QueueMapping:
{code}
public QueueMapping(MappingType type, String source, String queue) {
this.type = type;
this.source = source;
this.queue = queue;
this.parentQueue = null;
}
public QueueMapping(MappingType type, String source,
String queue, String parentQueue) {
this.type = type;
this.source = source;
this.queue = queue;
this.parentQueue = parentQueue;
}
{code}
2. Nit:
org.apache.hadoop.yarn.server.resourcemanager.placement.QueueMapping#DELIMITER
can be private
3. In UserGroupMappingPlacementRule#getPlacementForUser: Please put all builder
method calls to separate lines to improve readability. For example:
This could be changed:
{code}
QueueMapping queueMapping =
QueueMappingBuilder.create().type(mapping.getType())
.source(mapping.getSource()).queue(user)
.parentQueue(groups.getGroups(user).get(0)).build();
{code}
to:
{code}
QueueMapping queueMapping =
QueueMappingBuilder.create()
.type(mapping.getType())
.source(mapping.getSource()).queue(user)
.parentQueue(groups.getGroups(user).get(0))
.build();
{code}
Apart from these, patch looks good.
> Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping
> -------------------------------------------------------------
>
> Key: YARN-9970
> URL: https://issues.apache.org/jira/browse/YARN-9970
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-9970.001.patch, YARN-9970.002.patch,
> YARN-9970.003.patch, YARN-9970.004.patch, YARN-9970.005.patch,
> YARN-9970.006.patch, YARN-9970.007.patch, YARN-9970.008.patch
>
>
> Scope of this Jira is to refactor
> TestUserGroupMappingPlacementRule#verifyQueueMapping and QueueMapping class
> as discussed in
> https://issues.apache.org/jira/browse/YARN-9865?focusedCommentId=16971482&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16971482
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
