[
https://issues.apache.org/jira/browse/YARN-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985033#comment-16985033
]
Peter Bacsko commented on YARN-5106:
------------------------------------
Thanks for picking up the patch [~adam.antal].
Just minor a thing: strings like "drf" and "fair" are often repeated quite
often. Either
# Extract them to constants somewhere
# instead of using {{.defaultQueueSchedulingPolicy("drf")}} or
{{.schedulingPolicy("drf")}}, you can introduce methods like
{{.drfDefaultSchedulingPolicy()}} and {{.drfSchedulingPolicy()}},
{{.fairSchedulingPolicy()}}, etc.
# {{.queueMaxAMShareDefault(-1.0f)}}: here, the value -1.0f has a special
meaning (feature is disabled). Again, extract {{-1.0f}} or add a method
{{.disableQueueMaxAmShareDefault()}}.
# Placement rules like "specified", "reject", etc. Similarly to scheduling
policy, the set of accepted values are fixed. So do something which I
recommended in #2.
> Provide a builder interface for FairScheduler allocations for use in tests
> --------------------------------------------------------------------------
>
> Key: YARN-5106
> URL: https://issues.apache.org/jira/browse/YARN-5106
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Adam Antal
> Priority: Major
> Labels: newbie++
> Attachments: YARN-5106-branch-3.1.001.patch,
> YARN-5106-branch-3.1.001.patch, YARN-5106-branch-3.1.001.patch,
> YARN-5106-branch-3.1.002.patch, YARN-5106-branch-3.2.001.patch,
> YARN-5106-branch-3.2.001.patch, YARN-5106-branch-3.2.002.patch,
> YARN-5106.001.patch, YARN-5106.002.patch, YARN-5106.003.patch,
> YARN-5106.004.patch, YARN-5106.005.patch, YARN-5106.006.patch,
> YARN-5106.007.patch, YARN-5106.008.patch, YARN-5106.008.patch,
> YARN-5106.008.patch, YARN-5106.009.patch, YARN-5106.010.patch,
> YARN-5106.011.patch, YARN-5106.012.patch, YARN-5106.013.patch,
> YARN-5106.014.patch, YARN-5106.015.patch
>
>
> Most, if not all, fair scheduler tests create an allocations XML file. Having
> a helper class that potentially uses a builder would make the tests cleaner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
