[ 
https://issues.apache.org/jira/browse/YARN-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010225#comment-17010225
 ] 

Siddharth Ahuja edited comment on YARN-10063 at 1/8/20 1:04 AM:
----------------------------------------------------------------

Thanks [~pbacsko].

I have made the changes and uploaded the patch again that incorporates the 
changes discussed just above.

Usage output of both commands - LAUNCH_CONTAINER (1) and 
LAUNCH_DOCKER_CONTAINER (4) has been updated and it looks as per below:

{code}
[root@<host> bin]# pwd
/var/lib/yarn-ce/bin
[root@<host> bin]# ll
total 800
---Sr-s--- 1 root yarn 728960 Jan  7 16:37 container-executor
---Sr-s--- 1 root yarn  87168 Nov  8 08:04 container-executor.orig
[root@<host> bin]# ./container-executor

[root@sid-63-1 bin]# ./container-executor
Usage: container-executor --checksetup
       container-executor --mount-cgroups <hierarchy> <controller=path>...
[DISABLED] container-executor --tc-modify-state <command-file>
[DISABLED] container-executor --tc-read-state <command-file>
[DISABLED] container-executor --tc-read-stats <command-file>
[DISABLED] container-executor --exec-container <command-file>
[DISABLED] container-executor --run-docker <command-file>
[DISABLED] container-executor --remove-docker-container [hierarchy] 
<container_id>
[DISABLED] container-executor --inspect-docker-container <container_id>
[DISABLED] container-executor --run-runc-container <command-file>
[DISABLED] container-executor --reap-runc-layer-mounts <retain-count>
       container-executor <user> <yarn-user> <command> <command-args>
       where command and command-args: 
            initialize container:   0 appid tokens nm-local-dirs nm-log-dirs 
cmd app...
            launch container:       1 appid containerid workdir 
container-script tokens --http | --https keystorepath truststorepath pidfile 
nm-local-dirs nm-log-dirs resources 
 [DISABLED] launch docker container:       4 appid containerid workdir 
container-script tokens --http | --https keystorepath truststorepath pidfile 
nm-local-dirs nm-log-dirs docker-command-file resources 
            signal container:       2 container-pid signal
            delete as user:         3 relative-path
            list as user:           5 relative-path
[DISABLED]  sync yarn sysfs:        6 app-id nm-local-dirs
{code}

Thanks in advance again for your check [~pbacsko].


was (Author: sahuja):
Thanks [~pbacsko].

I have made the changes and uploaded the patch again that incorporates the 
changes discussed just above.

Usage output of both commands - LAUNCH_CONTAINER (1) and 
LAUNCH_DOCKER_CONTAINER (4) has been updated and it looks as per below:

{code}
[root@<host> bin]# pwd
/var/lib/yarn-ce/bin
[root@<host> bin]# ll
total 800
---Sr-s--- 1 root yarn 728960 Jan  7 16:37 container-executor
---Sr-s--- 1 root yarn  87168 Nov  8 08:04 container-executor.orig
[root@<host> bin]# ./container-executor

[root@sid-63-1 bin]# ./container-executor
Usage: container-executor --checksetup
       container-executor --mount-cgroups <hierarchy> <controller=path>...
[DISABLED] container-executor --tc-modify-state <command-file>
[DISABLED] container-executor --tc-read-state <command-file>
[DISABLED] container-executor --tc-read-stats <command-file>
[DISABLED] container-executor --exec-container <command-file>
[DISABLED] container-executor --run-docker <command-file>
[DISABLED] container-executor --remove-docker-container [hierarchy] 
<container_id>
[DISABLED] container-executor --inspect-docker-container <container_id>
[DISABLED] container-executor --run-runc-container <command-file>
[DISABLED] container-executor --reap-runc-layer-mounts <retain-count>
       container-executor <user> <yarn-user> <command> <command-args>
       where command and command-args: 
            initialize container:   0 appid tokens nm-local-dirs nm-log-dirs 
cmd app...
            launch container:       1 appid containerid workdir 
container-script tokens --http | --https keystorepath truststorepath pidfile 
nm-local-dirs nm-log-dirs resources 
 [DISABLED] launch docker container:       4 appid containerid workdir 
container-script tokens --http | --https keystorepath truststorepath pidfile 
nm-local-dirs nm-log-dirs docker-command-file resources 
            signal container:       2 container-pid signal
            delete as user:         3 relative-path
            list as user:           5 relative-path
[DISABLED]  sync yarn sysfs:        6 app-id nm-local-dirs
{code}

> Usage output of container-executor binary needs to include --http/--https 
> argument
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-10063
>                 URL: https://issues.apache.org/jira/browse/YARN-10063
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Siddharth Ahuja
>            Assignee: Siddharth Ahuja
>            Priority: Minor
>         Attachments: YARN-10063.001.patch, YARN-10063.002.patch
>
>
> YARN-8448/YARN-6586 seems to have introduced a new option - "\--http" 
> (default) and "\--https" that is possible to be passed in to the 
> container-executor binary, see :
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L564
> and 
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L521
> however, the usage output seems to have missed this:
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L74
> Raising this jira to improve this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to