[
https://issues.apache.org/jira/browse/YARN-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058328#comment-17058328
]
Siddharth Ahuja edited comment on YARN-10063 at 3/13/20, 1:18 AM:
------------------------------------------------------------------
Thanks [~wilfreds]. I have gone ahead and added a new patch based on your
earlier comments.
I have replaced *--http | --https keystorepath truststorepath* with
*http-option* and added the explanation of http-option to both launch container
& launch docker container commands. I also formatted the launch docker
container command slightly so that it looks a bit more neater.
It now looks like below:
{code:java}
[root@host bin]# ./container-executor
Usage: container-executor --checksetup
container-executor --mount-cgroups <hierarchy> <controller=path>...
[DISABLED] container-executor --tc-modify-state <command-file>
[DISABLED] container-executor --tc-read-state <command-file>
[DISABLED] container-executor --tc-read-stats <command-file>
[DISABLED] container-executor --exec-container <command-file>
[DISABLED] container-executor --run-docker <command-file>
[DISABLED] container-executor --remove-docker-container [hierarchy]
<container_id>
[DISABLED] container-executor --inspect-docker-container <container_id>
[DISABLED] container-executor --run-runc-container <command-file>
[DISABLED] container-executor --reap-runc-layer-mounts <retain-count>
container-executor <user> <yarn-user> <command> <command-args>
where command and command-args:
initialize container: 0 appid tokens nm-local-dirs nm-log-dirs
cmd app...
launch container: 1 appid containerid workdir
container-script tokens http-option pidfile nm-local-dirs nm-log-dirs resources
where http-option is one of:
--http
--https keystorepath truststorepath
[DISABLED] launch docker container: 4 appid containerid workdir
container-script tokens http-option pidfile nm-local-dirs nm-log-dirs
docker-command-file resources
where http-option is one of:
--http
--https keystorepath truststorepath
signal container: 2 container-pid signal
delete as user: 3 relative-path
list as user: 5 relative-path
[DISABLED] sync yarn sysfs: 6 app-id nm-local-dirs
{code}
Patch #003 is also attached for your review. Thanks in advance for checking!
was (Author: sahuja):
Thanks [~wilfreds]. I have gone ahead and added a new patch based on your
earlier comments.
I have replaced --http | --https keystorepath truststorepath with http-option
and added the explanation of http-option to both launch container & launch
docker container commands. I also formatted the launch docker container command
slightly so that it looks a bit more neater.
It now looks like below:
{code:java}
[root@host bin]# ./container-executor
Usage: container-executor --checksetup
container-executor --mount-cgroups <hierarchy> <controller=path>...
[DISABLED] container-executor --tc-modify-state <command-file>
[DISABLED] container-executor --tc-read-state <command-file>
[DISABLED] container-executor --tc-read-stats <command-file>
[DISABLED] container-executor --exec-container <command-file>
[DISABLED] container-executor --run-docker <command-file>
[DISABLED] container-executor --remove-docker-container [hierarchy]
<container_id>
[DISABLED] container-executor --inspect-docker-container <container_id>
[DISABLED] container-executor --run-runc-container <command-file>
[DISABLED] container-executor --reap-runc-layer-mounts <retain-count>
container-executor <user> <yarn-user> <command> <command-args>
where command and command-args:
initialize container: 0 appid tokens nm-local-dirs nm-log-dirs
cmd app...
launch container: 1 appid containerid workdir
container-script tokens http-option pidfile nm-local-dirs nm-log-dirs resources
where http-option is one of:
--http
--https keystorepath truststorepath
[DISABLED] launch docker container: 4 appid containerid workdir
container-script tokens http-option pidfile nm-local-dirs nm-log-dirs
docker-command-file resources
where http-option is one of:
--http
--https keystorepath truststorepath
signal container: 2 container-pid signal
delete as user: 3 relative-path
list as user: 5 relative-path
[DISABLED] sync yarn sysfs: 6 app-id nm-local-dirs
{code}
> Usage output of container-executor binary needs to include --http/--https
> argument
> ----------------------------------------------------------------------------------
>
> Key: YARN-10063
> URL: https://issues.apache.org/jira/browse/YARN-10063
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Siddharth Ahuja
> Assignee: Siddharth Ahuja
> Priority: Minor
> Attachments: YARN-10063.001.patch, YARN-10063.002.patch,
> YARN-10063.003.patch
>
>
> YARN-8448/YARN-6586 seems to have introduced a new option - "\--http"
> (default) and "\--https" that is possible to be passed in to the
> container-executor binary, see :
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L564
> and
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L521
> however, the usage output seems to have missed this:
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L74
> Raising this jira to improve this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
