[
https://issues.apache.org/jira/browse/YARN-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010548#comment-17010548
]
Wilfred Spiegelenburg commented on YARN-10063:
----------------------------------------------
Thank you review [~pbacsko] and for the update [~sahuja]
We need to add the usage correctly to the output. What I see at the moment does
not look correct.The output indicates that we have {{--http | --https}} It does
not show that the two parameters following the "choice" are only supported with
the https option.
Not sure how we can show that better, we might need to go to partially back to
the way [~sahuja] did show it in the first version and use the same construct
as used for the {{command and command-args}} to provide the detail needed, so
something like:
{quote}where command and command-args:
initialize container: 0 appid tokens nm-local-dirs nm-log-dirs cmd app...
launch container: 1 appid containerid workdir container-script tokens
*http-option* pidfile nm-local-dirs nm-log-dirs resources
optional-tc-command-file
[DISABLED] launch docker container: 4 appid containerid
...
where http-option is one of:
--http
--https keystorepath truststorepath
{quote}
A bit difficult to show in jira but I think you get the gist.
> Usage output of container-executor binary needs to include --http/--https
> argument
> ----------------------------------------------------------------------------------
>
> Key: YARN-10063
> URL: https://issues.apache.org/jira/browse/YARN-10063
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Siddharth Ahuja
> Assignee: Siddharth Ahuja
> Priority: Minor
> Attachments: YARN-10063.001.patch, YARN-10063.002.patch
>
>
> YARN-8448/YARN-6586 seems to have introduced a new option - "\--http"
> (default) and "\--https" that is possible to be passed in to the
> container-executor binary, see :
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L564
> and
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L521
> however, the usage output seems to have missed this:
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L74
> Raising this jira to improve this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
