[ https://issues.apache.org/jira/browse/YARN-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058343#comment-17058343 ]
Siddharth Ahuja commented on YARN-10063: ---------------------------------------- Thanks [~wilfreds], the spacing before the modifier is intentional as it brings in the number closer and makes it neater. Before: {code:java} where command and command-args: initialize container: 0 appid tokens nm-local-dirs nm-log-dirs cmd app... launch container: 1 appid containerid workdir container-script tokens --http | --https keystorepath truststorepath pidfile nm-local-dirs nm-log-dirs resources [DISABLED] launch docker container: 4 appid containerid workdir container-script tokens --http | --https keystorepath truststorepath pidfile nm-local-dirs nm-log-dirs docker-command-file resources ... {code} After: {code:java} where command and command-args: initialize container: 0 appid tokens nm-local-dirs nm-log-dirs cmd app... launch container: 1 appid containerid workdir container-script tokens http-option pidfile nm-local-dirs nm-log-dirs resources where http-option is one of: --http --https keystorepath truststorepath [DISABLED] launch docker container: 4 appid containerid workdir container-script tokens http-option pidfile nm-local-dirs nm-log-dirs docker-command-file resources ... {code} The spaces next to the ":" are varying. That is to say, they are not consistent per command. Therefore, I could modify them to look neater and not break anything. > Usage output of container-executor binary needs to include --http/--https > argument > ---------------------------------------------------------------------------------- > > Key: YARN-10063 > URL: https://issues.apache.org/jira/browse/YARN-10063 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Siddharth Ahuja > Assignee: Siddharth Ahuja > Priority: Minor > Attachments: YARN-10063.001.patch, YARN-10063.002.patch, > YARN-10063.003.patch > > > YARN-8448/YARN-6586 seems to have introduced a new option - "\--http" > (default) and "\--https" that is possible to be passed in to the > container-executor binary, see : > https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L564 > and > https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L521 > however, the usage output seems to have missed this: > https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L74 > Raising this jira to improve this. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org