[ 
https://issues.apache.org/jira/browse/YARN-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018214#comment-17018214
 ] 

Íñigo Goiri commented on YARN-8529:
-----------------------------------

Thanks [~minni31] for the update; let's take care of one of the checkstyle and 
a couple more things:
* Instead of having "ms", we now support any unit, so we can call them 
"connect-timeout" and "read-timeout" same for the constant name.
* Do we need to add this to yarn-default.xml? There we can present the fact 
that is a time period and set the value to "30s".
* For the style we can do
{code}
client.setConnectTimeout((int) conf.getTimeDuration(
    YarnConfiguration.ROUTER_WEBAPP_CONNECT_TIMEOUT_MS,
    YarnConfiguration.DEFAULT_ROUTER_WEBAPP_CONNECT_TIMEOUT_MS,
    TimeUnit.MILLISECONDS));
client.setReadTimeout((int) conf.getTimeDuration(
    YarnConfiguration.ROUTER_WEBAPP_READ_TIMEOUT_MS,
    YarnConfiguration.DEFAULT_ROUTER_WEBAPP_READ_TIMEOUT_MS,
    TimeUnit.MILLISECONDS));
{code}


> Add timeout to RouterWebServiceUtil#invokeRMWebService
> ------------------------------------------------------
>
>                 Key: YARN-8529
>                 URL: https://issues.apache.org/jira/browse/YARN-8529
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Íñigo Goiri
>            Assignee: Minni Mittal
>            Priority: Major
>         Attachments: YARN-8529.v1.patch, YARN-8529.v2.patch, 
> YARN-8529.v3.patch, YARN-8529.v4.patch, YARN-8529.v5.patch
>
>
> {{RouterWebServiceUtil#invokeRMWebService}} currently has a fixed timeout. 
> This should be configurable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to