[
https://issues.apache.org/jira/browse/YARN-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020931#comment-17020931
]
Wilfred Spiegelenburg commented on YARN-9879:
---------------------------------------------
I agree, {{getQueueName()}} should stay as is. We have a {{getQueuePath()}}
already. Every CSQueue can already return both. We should change all non
external facing calls getting the name of a queue to the path version. The only
calls that can stay are the ones that provide their data in an externally
viewable form (REST, UI or IPC) as to not break compatibility.
I also do not see why we would need the ambiguous queue list. The queue is
always unique when a path is used. It does not matter if the current leaf queue
name uniqueness is enforced or not.
Everything can always be found by its path. If I do not have a path I expect
leaf queue uniqueness and can find the queue by just checking the part after
the last _dot_ in the path.
i.e.
* queue paths defined as: root.parent.child1
child queue unique flag is set
find a queue with name: *child1* (no dots, expect leaf queue uniqueness) ->
returns the queue correctly
* add a queue defined as: root.otherparent.child1
child queue unique flag is not set, allowed
find a queue with name: *child1* (no dots, expect leaf queue uniqueness) ->
returns an error
Internally we just store everything using the path, that would remove the whole
keeping things in sync and makes the code consistent when combined with using
the path everywhere internally
> Allow multiple leaf queues with the same name in CS
> ---------------------------------------------------
>
> Key: YARN-9879
> URL: https://issues.apache.org/jira/browse/YARN-9879
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: DesignDoc_v1.pdf, YARN-9879.POC001.patch
>
>
> Currently the leaf queue's name must be unique regardless of its position in
> the queue hierarchy.
> Design doc and first proposal is being made, I'll attach it as soon as it's
> done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
