[
https://issues.apache.org/jira/browse/YARN-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021651#comment-17021651
]
Wangda Tan commented on YARN-9879:
----------------------------------
Thanks [~shuzirra], [~wilfreds] for sharing your thoughts!
1) Regarding change semantics of GetQueueName() to return full qualified queue
name v.s. use GetQueuePath:
If we decide to go the first route, we need to remove usages of
AbstractCSQueue.GetQueuePath (which has 128 usages), and add a
GetShortQueueName in some places. So to me, there are no significant
differences to just change internal CS usages to use GetQueuePath().
2) No matter which way we decided to go, I think we should make sure that:
API compatibility, this is critical since I assume there're lots of monitoring
framework, JMX metrics, etc. based on this. If we upgrade an existing CS-based
cluster, they should expect the same result. Please refer to API compatibility:
[https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html]
Internal usage of GetQueuePath (or GetShortQueueName if we choose proposed
approach). And externally, we should make sure we can get a queue by short
name, or long name. I want to make sure we only check short name / long name in
external call (like submit app to specified queue), and in all other places, we
use the full queue path to operate. I think introducing a new CSQueueStore
sounds good, but I recommend to add a separate method to CSQueueStore to check
both short/long names and make it used by external callers only (And in
contrast, internal CS method should check only one HashMap instead of two). We
can review details of CSQueueStore separately.
> Allow multiple leaf queues with the same name in CS
> ---------------------------------------------------
>
> Key: YARN-9879
> URL: https://issues.apache.org/jira/browse/YARN-9879
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Attachments: DesignDoc_v1.pdf, YARN-9879.POC001.patch
>
>
> Currently the leaf queue's name must be unique regardless of its position in
> the queue hierarchy.
> Design doc and first proposal is being made, I'll attach it as soon as it's
> done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
