[ 
https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021613#comment-17021613
 ] 

Eric Badger commented on YARN-10084:
------------------------------------

Hey [~epayne], the patch looks good, but I have a comment about the tests. 
You've added a test to make sure that leaf queues correctly inherit their 
parent's default and max lifetimes. Could you also add a test to check that the 
leaf queue is able to override the parent's default and max lifetimes?

> Allow inheritance of max app lifetime / default app lifetime
> ------------------------------------------------------------
>
>                 Key: YARN-10084
>                 URL: https://issues.apache.org/jira/browse/YARN-10084
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>    Affects Versions: 2.10.0, 3.2.1, 3.1.3
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>            Priority: Major
>         Attachments: YARN-10084.001.patch, YARN-10084.002.patch, 
> YARN-10084.003.patch, YARN-10084.004.patch
>
>
> Currently, {{maximum-application-lifetime}} and 
> {{default-application-lifetime}} must be set for each leaf queue. If it is 
> not set for a particular leaf queue, then there will be no time limit on apps 
> running in that queue. It should be possible to set 
> {{yarn.scheduler.capacity.root.maximum-application-lifetime}} for the root 
> queue and allow child queues to override that value if desired.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to