[ 
https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021401#comment-17021401
 ] 

Jim Brennan commented on YARN-10084:
------------------------------------

Thanks for the update [~epayne]!  The code looks good to me.  One comment on 
the documentation:
{quote}`yarn.scheduler.capacity.root.<queue-path>.default-application-lifetime` 
| Default lifetime (in seconds) of an application which is submitted to a 
queue.  Any value less than or equal to zero will be considered as disabled. If 
the user has not submitted application with lifetime value then this value will 
be taken. It is point-in-time configuration. This feature can be set at any 
level in the queue hierarchy.  Child queues will inherit their parent's value 
unless overridden at the child level.

Child queues can set this property to a value less than or equal to their 
parent's value.
{quote}
This sentence is inaccurate. Maybe just remove it or change to something like: 
If a child queue inherits this from the parent and the parent value is greater 
than the child's max value, the child's max value will be used for the default.
{quote}If set to 0, all the queue's max value must also be
 unlimited. Note : Default lifetime (if set at this level) can't exceed maximum 
lifetime.
{quote}

> Allow inheritance of max app lifetime / default app lifetime
> ------------------------------------------------------------
>
>                 Key: YARN-10084
>                 URL: https://issues.apache.org/jira/browse/YARN-10084
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>    Affects Versions: 2.10.0, 3.2.1, 3.1.3
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>            Priority: Major
>         Attachments: YARN-10084.001.patch, YARN-10084.002.patch
>
>
> Currently, {{maximum-application-lifetime}} and 
> {{default-application-lifetime}} must be set for each leaf queue. If it is 
> not set for a particular leaf queue, then there will be no time limit on apps 
> running in that queue. It should be possible to set 
> {{yarn.scheduler.capacity.root.maximum-application-lifetime}} for the root 
> queue and allow child queues to override that value if desired.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to