[
https://issues.apache.org/jira/browse/YARN-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029996#comment-17029996
]
Adam Antal commented on YARN-10101:
-----------------------------------
Thanks for the review [~snemeth]! Your comment were very valuable.
I fixed items 1, 4, 7, 8, 9, 11, 14, 15.
Item 2: YARN-10106
Item 3: Yes, this is intentional. In that loop we filter all the containers, or
just for the containerId that we requested. Now we can also filter for
application attempt if that condition is true. This is an additional check, and
we default return false in that function - so it will only take effect, if app
attempt id is added to the request object.
Item 5: This should be a quite common branch, so I'd refrain myself from
raising to ERROR level. I raised to WARN, so that we have an agreement.
Item 6: I also refactored a bit more to only check, if those arguments are
provided.
Item 10: For clarity I'd like to keep it as it is - I think it's better to see
the whole url, so that you know which API endpoints we're calling.
Item 12 & 13: I killed two birds with one stone - please check.
As you brought attention to the {{BadRequestException}} class, I added 7 new
unit tests that check if bad or non-existing app id/ app attempt id/container
id is provided.
> Support listing of aggregated logs for containers belonging to an application
> attempt
> -------------------------------------------------------------------------------------
>
> Key: YARN-10101
> URL: https://issues.apache.org/jira/browse/YARN-10101
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: log-aggregation, yarn
> Affects Versions: 3.3.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: YARN-10101.001.patch, YARN-10101.002.patch,
> YARN-10101.003.patch, YARN-10101.004.patch, YARN-10101.005.patch,
> YARN-10101.006.patch
>
>
> To display logs without access to the timeline server, we need an interface
> where we can query the list of containers with aggregated logs belonging to
> an application attempt.
> We should add support for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
