[
https://issues.apache.org/jira/browse/YARN-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030609#comment-17030609
]
Szilard Nemeth commented on YARN-10101:
---------------------------------------
Hi [~adam.antal],
Thanks for updating the patch.
Here is my response:
1 - Fix looks good
2 - ACK
3 - ACK
4 - Fix looks good
5 - I'm fine with the WARNING level. You missed one occurrence though:
line 365: LOG.info("Could not obtain node HTTP address from provider.", ex);
6 - Fix looks good in getLogsInfo. However, the caught IllegalArgumentException
instances are called "ignore", but in fact, they are not ignored and this is
quite confusing. Please rename them to "e" or something else.
7 - OK
8 - OK
9 - Can you add another comment for the 2nd doAnswer call (mocking) as well?
10 - ACK
11 - assertResponseList looks good to me
12 & 13 - assertSimpleContainerLogFileInfo looks good to me
14 - OK
15 - OK
> Support listing of aggregated logs for containers belonging to an application
> attempt
> -------------------------------------------------------------------------------------
>
> Key: YARN-10101
> URL: https://issues.apache.org/jira/browse/YARN-10101
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: log-aggregation, yarn
> Affects Versions: 3.3.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: YARN-10101.001.patch, YARN-10101.002.patch,
> YARN-10101.003.patch, YARN-10101.004.patch, YARN-10101.005.patch,
> YARN-10101.006.patch, YARN-10101.007.patch, YARN-10101.008.patch
>
>
> To display logs without access to the timeline server, we need an interface
> where we can query the list of containers with aggregated logs belonging to
> an application attempt.
> We should add support for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
