[ 
https://issues.apache.org/jira/browse/YARN-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090858#comment-17090858
 ] 

Wei-Chiu Chuang commented on YARN-10063:
----------------------------------------

YARN-10063 is in branch-3.2 and broke the build 
[https://github.com/apache/hadoop/pull/1973]

 
{noformat}
[WARNING] make[1]: Leaving directory 
'/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1973/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native'
[WARNING] Makefile:76: recipe for target 'all' failed
[WARNING] 
/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1973/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c:
 In function 'display_usage':
[WARNING] 
/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1973/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c:89:3:
 error: 'de' undeclared (first use in this function)
[WARNING]    de = is_docker_support_enabled() ? enabled : disabled;
[WARNING]    ^
[WARNING] 
/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1973/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c:89:3:
 note: each undeclared identifier is reported only once for each function it 
appears in
[WARNING] 
/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1973/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c:89:38:
 error: 'enabled' undeclared (first use in this function)
[WARNING]    de = is_docker_support_enabled() ? enabled : disabled;
[WARNING]                                       ^
[WARNING] 
/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1973/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c:89:48:
 error: 'disabled' undeclared (first use in this function)
[WARNING]    de = is_docker_support_enabled() ? enabled : disabled;
[WARNING]                                                 ^
[WARNING] make[2]: *** 
[CMakeFiles/container-executor.dir/main/native/container-executor/impl/main.c.o]
 Error 1
[WARNING] make[1]: *** [CMakeFiles/container-executor.dir/all] Error 2
[WARNING] make[1]: *** Waiting for unfinished jobs.... {noformat}

I'll revert the commit from branch-3.2 since it's blocking precommits.

> Usage output of container-executor binary needs to include --http/--https 
> argument
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-10063
>                 URL: https://issues.apache.org/jira/browse/YARN-10063
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Siddharth Ahuja
>            Assignee: Siddharth Ahuja
>            Priority: Minor
>             Fix For: 3.3.0, 3.4.0
>
>         Attachments: YARN-10063.001.patch, YARN-10063.002.patch, 
> YARN-10063.003.patch, YARN-10063.004.patch
>
>
> YARN-8448/YARN-6586 seems to have introduced a new option - "\--http" 
> (default) and "\--https" that is possible to be passed in to the 
> container-executor binary, see :
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L564
> and 
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L521
> however, the usage output seems to have missed this:
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c#L74
> Raising this jira to improve this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to