[
https://issues.apache.org/jira/browse/YARN-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064750#comment-17064750
]
Peter Bacsko commented on YARN-10198:
-------------------------------------
Due to infra issues, we can't see the comment about the Precommit builds.
Here's a build about patch v3:
https://builds.apache.org/job/PreCommit-YARN-Build/25730/console
{noformat}
+1 overall
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 48s | Docker mode activated.
| | | | Prechecks
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or
| | | | modified test files.
| | | | trunk Compile Tests
| +1 | mvninstall | 20m 57s | trunk passed
| +1 | compile | 0m 43s | trunk passed
| +1 | checkstyle | 0m 34s | trunk passed
| +1 | mvnsite | 0m 46s | trunk passed
| +1 | shadedclient | 15m 27s | branch has no errors when building and
| | | | testing our client artifacts.
| +1 | findbugs | 1m 34s | trunk passed
| +1 | javadoc | 0m 29s | trunk passed
| | | | Patch Compile Tests
| +1 | mvninstall | 0m 42s | the patch passed
| +1 | compile | 0m 37s | the patch passed
| +1 | javac | 0m 37s | the patch passed
| +1 | checkstyle | 0m 28s | the patch passed
| +1 | mvnsite | 0m 41s | the patch passed
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | shadedclient | 14m 2s | patch has no errors when building and
| | | | testing our client artifacts.
| +1 | findbugs | 1m 37s | the patch passed
| +1 | javadoc | 0m 28s | the patch passed
| | | | Other Tests
| +1 | unit | 89m 8s | hadoop-yarn-server-resourcemanager in
| | | | the patch passed.
| +1 | asflicense | 0m 26s | The patch does not generate ASF
| | | | License warnings.
| | | 149m 17s |
{noformat}
[~sunilg] [~prabhujoseph] could you guys commit this change?
> [managedParent].%primary_group mapping rule doesn't work after YARN-9868
> ------------------------------------------------------------------------
>
> Key: YARN-10198
> URL: https://issues.apache.org/jira/browse/YARN-10198
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-10198-001.patch, YARN-10198-002.patch,
> YARN-10198-003.patch
>
>
> YARN-9868 introduced an unnecessary check if we have the following placement
> rule:
> [managedParentQueue].%primary_group
> Here, {{%primary_group}} is expected to be created if it doesn't exist.
> However, there is this validation code which is not necessary:
> {noformat}
> } else if (mapping.getQueue().equals(PRIMARY_GROUP_MAPPING)) {
> if (this.queueManager
> .getQueue(groups.getGroups(user).get(0)) != null) {
> return getPlacementContext(mapping,
> groups.getGroups(user).get(0));
> } else {
> return null;
> }
> {noformat}
> We should revert this part to the original version:
> {noformat}
> } else if (mapping.queue.equals(PRIMARY_GROUP_MAPPING)) {
> return getPlacementContext(mapping,
> groups.getGroups(user).get(0));
> }
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
