[
https://issues.apache.org/jira/browse/YARN-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated YARN-1395:
-----------------------------------------
Hadoop Flags: Reviewed
+1 patch looks good.
Just a minor code style comment. See if it makes sense:
{code}
+ sr = new StringReader(lines);
+ buf = new BufferedReader(sr);
{code}
I think we don't need a separated sr variable for StringReader and we don't
need to close it separately. We may put them in one line
{code}
+ buf = new BufferedReader(new StringReader(lines));
{code}
When buf.close() is called, it will close the underlying stream; see [the
source
code|http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/7-b147/java/io/BufferedReader.java#BufferedReader.close%28%29].
> Distributed shell application master launched with debug flag can hang
> waiting for external ls process.
> -------------------------------------------------------------------------------------------------------
>
> Key: YARN-1395
> URL: https://issues.apache.org/jira/browse/YARN-1395
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications/distributed-shell
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: YARN-1395.1.patch
>
>
> Distributed shell launched with the debug flag will run
> {{ApplicationMaster#dumpOutDebugInfo}}. This method launches an external
> process to run ls and print the contents of the current working directory.
> We've seen that this can cause the application master to hang on
> {{Process#waitFor}}.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
