[ 
https://issues.apache.org/jira/browse/YARN-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096872#comment-17096872
 ] 

Jonathan Turner Eagles commented on YARN-10255:
-----------------------------------------------

I see a 4k patch, which is pretty substantial, but don't see an analysis that 
shows the need for these changes. Is the effective change besides the 
refactoring (lambda) just to change the delay on the scheduler? If not please 
help explain the changes along with the analysis.

> revisit fix to intermittent 
> TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10255
>                 URL: https://issues.apache.org/jira/browse/YARN-10255
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: unit-test
>         Attachments: YARN-10255-branch-2.10.001.patch, YARN-10255.001.patch
>
>
> Creating this Jira to fix intermittent failure in branch-2.10. Also, the fix 
> in YARN-7372 has some redundancy in assertion that could be removed.
> UT failure in branch-2.10:
>  {noformat}
> testContainerUpdateExecTypeGuaranteedToOpportunistic:
>  <failure type='java.lang.AssertionError' 
> message='expected:&lt;OPPORTUNISTIC&gt; but 
> was:&lt;GUARANTEED&gt;'><![CDATA[java.lang.AssertionError: 
> expected:<OPPORTUNISTIC> but was:<GUARANTEED>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:144)
>       at 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler.TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic(TestContainerSchedulerQueuing.java:1269)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to