[
https://issues.apache.org/jira/browse/YARN-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096886#comment-17096886
]
Ahmed Hussein commented on YARN-10255:
--------------------------------------
Thanks [~jeagles]
For 3.x there assertion are redundant. since the UT throws timeout exception,
{{GenericTestsUtils.waitFor()}} guarantees that the predicate is met
successfully. Otherwise, the UT would throw a timeout exception.
Since I needed to fix the same unit test for 2.10, I found it will be good to
take the opportunity and reduce the poll interval, and remove the redundant
loop to make the loop as it was confusing to understand what was the purpose
of it.
> revisit fix to intermittent
> TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic
> --------------------------------------------------------------------------------------------------------------
>
> Key: YARN-10255
> URL: https://issues.apache.org/jira/browse/YARN-10255
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: unit-test
> Attachments: YARN-10255-branch-2.10.001.patch, YARN-10255.001.patch
>
>
> Creating this Jira to fix intermittent failure in branch-2.10. Also, the fix
> in YARN-7372 has some redundancy in assertion that could be removed.
> UT failure in branch-2.10:
> {noformat}
> testContainerUpdateExecTypeGuaranteedToOpportunistic:
> <failure type='java.lang.AssertionError'
> message='expected:<OPPORTUNISTIC> but
> was:<GUARANTEED>'><![CDATA[java.lang.AssertionError:
> expected:<OPPORTUNISTIC> but was:<GUARANTEED>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler.TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic(TestContainerSchedulerQueuing.java:1269)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
