[
https://issues.apache.org/jira/browse/YARN-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101814#comment-17101814
]
Manikandan R commented on YARN-6492:
------------------------------------
1:
We had two different method names till .006.patch. Based on our later
discussions, simplified the code in .007.patch based on the thinking
getPartitionQueueMetrics in QueueMetrics meant for Partition * Queue metric
computation, whereas, getPartitionQueueMetrics in PartitionQueueMetrics meant
for Partition metric computation. Since PartitionQueueMetrics is an extension
of QueueMetrics, we had same method names and functionality has been overridden
for each of its need. However, comments are not clear. Modified the comments in
.008.patch.
2,3:
This Jira and YARN-9767 has to go in same time. Otherwise, as a feature, it
won't be complete as such. It is just that we are handling the issues
separately in YARN-9767 for better code review. YARN-9767 answers most of the
concerns raised in #2, #3. For example, YARN-9767 contains very exhaustive test
asserts which can clear up lot of confusions and enhance our understanding.
If it is confusing to have two different patches, we will need to decide on how
to take this further. If you think, both Jira should be taken up in same patch
for code completeness perspective, then let's do that. We can follow any one of
the path which is convenient for us. Thoughts?
4:
Yes, We can do.
> Generate queue metrics for each partition
> -----------------------------------------
>
> Key: YARN-6492
> URL: https://issues.apache.org/jira/browse/YARN-6492
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: Jonathan Hung
> Assignee: Manikandan R
> Priority: Major
> Attachments: PartitionQueueMetrics_default_partition.txt,
> PartitionQueueMetrics_x_partition.txt, PartitionQueueMetrics_y_partition.txt,
> YARN-6492.001.patch, YARN-6492.002.patch, YARN-6492.003.patch,
> YARN-6492.004.patch, YARN-6492.005.WIP.patch, YARN-6492.006.WIP.patch,
> YARN-6492.007.WIP.patch, partition_metrics.txt
>
>
> We are interested in having queue metrics for all partitions. Right now each
> queue has one QueueMetrics object which captures metrics either in default
> partition or across all partitions. (After YARN-6467 it will be in default
> partition)
> But having the partition metrics would be very useful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
