[
https://issues.apache.org/jira/browse/YARN-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102945#comment-17102945
]
Eric Payne commented on YARN-6492:
----------------------------------
Thanks [[email protected]] for working to move this issue forward, and
thanks [~jhung] for the great reviews.
Mani, I try to build patch 008 on trunk, and it gives me the following
compilation errors:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project hadoop-yarn-server-resourcemanager: Compilation failure
[ERROR]
/home/ericp/hadoop/source/YARN-6492/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/QueueMetrics.java:[320,39]
cannot find symbol
[ERROR] symbol: class PartitionQueueMetrics
[ERROR] location: class
org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetrics
{noformat}
As I mentioned [in this comment,
above|https://issues.apache.org/jira/browse/YARN-6492?focusedCommentId=16903050&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16903050],
I am concerned about naming the default partition "default":
{code:java}
public static final String DEFAULT_PARTITION = "default";
{code}
Will the field names for the default partition come out as follows?
{panel}
"name": "Hadoop:service=ResourceManager,name=PartitionQueueMetrics,p0=default"
"tag.Partition": "default"
{panel}
In order to be consistent with other API responses like
{{/ws/v1/cluster/scheduler}}, I think this should just be an empty string. So,
I would expect the JMX response to look like the following for
DEFAULT_PARTITION:
{panel}
"name": "Hadoop:service=ResourceManager,name=PartitionQueueMetrics,p0="
"tag.Partition": ""
{panel}
{quote}
IMO the bottom line is that after this JIRA is committed, the existing
QueueMetrics should still only contain metrics for default partition, and
partitioned queue metrics should only be in the newly added metrics.
{quote}
I agree with Jonathan's statement.
> Generate queue metrics for each partition
> -----------------------------------------
>
> Key: YARN-6492
> URL: https://issues.apache.org/jira/browse/YARN-6492
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: Jonathan Hung
> Assignee: Manikandan R
> Priority: Major
> Attachments: PartitionQueueMetrics_default_partition.txt,
> PartitionQueueMetrics_x_partition.txt, PartitionQueueMetrics_y_partition.txt,
> YARN-6492.001.patch, YARN-6492.002.patch, YARN-6492.003.patch,
> YARN-6492.004.patch, YARN-6492.005.WIP.patch, YARN-6492.006.WIP.patch,
> YARN-6492.007.WIP.patch, YARN-6492.008.WIP.patch, partition_metrics.txt
>
>
> We are interested in having queue metrics for all partitions. Right now each
> queue has one QueueMetrics object which captures metrics either in default
> partition or across all partitions. (After YARN-6467 it will be in default
> partition)
> But having the partition metrics would be very useful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
