[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820036#comment-13820036
]
Karthik Kambatla commented on YARN-1222:
----------------------------------------
Thanks Bikas. The new patch addresses all your comments.
bq. In default fencing, we rely on the default zkacl to allow shared admin
access for both RM's right? Can we document that please?
yarn-default.xml documents this.
bq. Should these and others in handleStoreEvent() be inside the try block.
Good catch! The updated patch fixes this.
bq. Log in main and catch block and before ExitUtil would help in debugging.
Added log messages.
bq. Why is there a new synchronized block here? What needs to be guarded
against concurrent modification?
numRetries - findbugs reported this on an earlier version of the patch.
Fixed comments on the test.
> Make improvements in ZKRMStateStore for fencing
> -----------------------------------------------
>
> Key: YARN-1222
> URL: https://issues.apache.org/jira/browse/YARN-1222
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Karthik Kambatla
> Attachments: yarn-1222-1.patch, yarn-1222-2.patch, yarn-1222-3.patch,
> yarn-1222-4.patch, yarn-1222-5.patch, yarn-1222-6.patch, yarn-1222-7.patch,
> yarn-1222-8.patch, yarn-1222-8.patch, yarn-1222-9.patch
>
>
> Using multi-operations for every ZK interaction.
> In every operation, automatically creating/deleting a lock znode that is the
> child of the root znode. This is to achieve fencing by modifying the
> create/delete permissions on the root znode.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
