[
https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126919#comment-17126919
]
Bilwa S T commented on YARN-9460:
---------------------------------
Hi [~pbacsko]
Thanks for review. Yes you are correct. behaviour wont change in this case. I
had this in mind but was not sure. I have uploaded patch. Please take a look at
it
> QueueACLsManager and ReservationsACLManager should not use instanceof checks
> ----------------------------------------------------------------------------
>
> Key: YARN-9460
> URL: https://issues.apache.org/jira/browse/YARN-9460
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Bilwa S T
> Priority: Major
> Attachments: YARN-9460.001.patch, YARN-9460.002.patch,
> YARN-9460.003.patch
>
>
> QueueACLsManager and ReservationsACLManager should not use instanceof checks
> for the scheduler type.
> Rather, we should abstract this into two classes: Capacity and Fair variants
> of these ACL classes.
> QueueACLsManager and ReservationsACLManager could be abstract classes, but
> the implementation is the decision of one who will work on this jira.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
