[
https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130411#comment-17130411
]
Peter Bacsko commented on YARN-9460:
------------------------------------
Thanks for the new patch [~BilwaST]. There are some checkstyle
"VisibilityModifier" complaints. Please validate if those are legitimate or not
(I can see that they're package private). If they're accessed in the descendant
classes, make them protected. If package private is legit, then add
{{@SuppressWarnings("checkstyle:visibilitymodifier")}} to the class.
> QueueACLsManager and ReservationsACLManager should not use instanceof checks
> ----------------------------------------------------------------------------
>
> Key: YARN-9460
> URL: https://issues.apache.org/jira/browse/YARN-9460
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Bilwa S T
> Priority: Major
> Attachments: YARN-9460.001.patch, YARN-9460.002.patch,
> YARN-9460.003.patch, YARN-9460.004.patch
>
>
> QueueACLsManager and ReservationsACLManager should not use instanceof checks
> for the scheduler type.
> Rather, we should abstract this into two classes: Capacity and Fair variants
> of these ACL classes.
> QueueACLsManager and ReservationsACLManager could be abstract classes, but
> the implementation is the decision of one who will work on this jira.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
