[ 
https://issues.apache.org/jira/browse/YARN-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bilwa S T updated YARN-10308:
-----------------------------
    Summary: Update javadoc and variable names for keytab in yarn services as 
it supports filesystems other than hdfs and local file system  (was: Update 
javadoc and variable names for keytab in yarn services as it supports schemes 
other than hdfs and local file system)

> Update javadoc and variable names for keytab in yarn services as it supports 
> filesystems other than hdfs and local file system
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10308
>                 URL: https://issues.apache.org/jira/browse/YARN-10308
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bilwa S T
>            Assignee: Bilwa S T
>            Priority: Minor
>
> 1.  Below description should be updated
> {code:java}
> @ApiModelProperty(value = "The URI of the kerberos keytab. It supports two " +
>       "schemes \"hdfs\" and \"file\". If the URI starts with \"hdfs://\" " +
>       "scheme, it indicates the path on hdfs where the keytab is stored. The 
> " +
>       "keytab will be localized by YARN and made available to AM in its 
> local" +
>       " directory. If the URI starts with \"file://\" scheme, it indicates a 
> " +
>       "path on the local host where the keytab is presumbaly installed by " +
>       "admins upfront. ")
>   public String getKeytab() {
>     return keytab;
>   }
> {code}
> 2. Variables below are still named on hdfs which is confusing
> {code:java}
> if ("file".equals(keytabURI.getScheme())) {
>       LOG.info("Using a keytab from localhost: " + keytabURI);
>     } else {
>       Path keytabOnhdfs = new Path(keytabURI);
>       if (!fileSystem.getFileSystem().exists(keytabOnhdfs)) {
>         LOG.warn(service.getName() + "'s keytab (principalName = "
>             + principalName + ") doesn't exist at: " + keytabOnhdfs);
>         return;
>       }
>       LocalResource keytabRes = fileSystem.createAmResource(keytabOnhdfs,
>           LocalResourceType.FILE);
>       localResource.put(String.format(YarnServiceConstants.KEYTAB_LOCATION,
>           service.getName()), keytabRes);
>       LOG.info("Adding " + service.getName() + "'s keytab for "
>           + "localization, uri = " + keytabOnhdfs);
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to