Hudáky Márton Gyula commented on YARN-10304:

Thanks for the effort, [~gandras].
Non-binding +1
One nit found to simplify the magic with the configurations in 
TestHsWebServicesLogs, like this:
private Configuration usedConf;

WebServletModule() {
  this.usedConf = conf;

WebServletModule(Configuration newConf) {
  this.usedConf = newConf;

> Create an endpoint for remote application log directory path query
> ------------------------------------------------------------------
>                 Key: YARN-10304
>                 URL: https://issues.apache.org/jira/browse/YARN-10304
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Minor
>         Attachments: YARN-10304.001.patch, YARN-10304.002.patch, 
> YARN-10304.003.patch, YARN-10304.004.patch, YARN-10304.005.patch, 
> YARN-10304.006.patch
> The logic of the aggregated log directory path determination (currently based 
> on configuration) is scattered around the codebase and duplicated multiple 
> times. By providing a separate class for creating the path for a specific 
> user, it allows for an abstraction over this logic. This could be used in 
> place of the previously duplicated logic, moreover, we could provide an 
> endpoint to query this path.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to